search

epics-base / normativeTypesCPP

normativeTypesCPP is an EPICS V4 C++ module
http://epics-pvdata.sourceforge.net/index.html
Other
2 stars 8 forks source link

Unchecked calls to getField(), getSubField(), etc. #14

Open mdavidsaver opened 6 years ago

mdavidsaver commented 6 years ago

This module needs to be audited for unchecked calls to methods which can return NULL. This is especially problematic in the isCompatible() methods which are intended to be used on suspect type definitions.

https://github.com/epics-base/normativeTypesCPP/blob/5e151c3b7a23ec4f04332b587349c6ae542d4dd2/src/ntndarray.cpp#L352

cf. areaDetector/ADCore#296

mdavidsaver commented 6 years ago

The specific issue with NTNDArray is fixed by 91c51368833fb04b32f478f3af65179de6551ff7. I'm going to leave this issue open pending a audit for similar issues.