search

epics-base / pvAccessCPP

pvAccessCPP is an EPICS V4 C++ module
https://epics-base.github.io/pvAccessCPP/
Other
10 stars 22 forks source link

add default message for pvget #195

Open rerpha opened 7 months ago

rerpha commented 7 months ago

Adds a default message for pvget. I don't know if line 363 (the default case) was a bug as i could never get it to run. @ralphlange I found this after I showed you my (accidentally?) working PVAccess.

Maybe there's a good reason that pvget doesn't have this line but the other tools do, please let me know!

AppVeyorBot commented 7 months ago

:white_check_mark: Build pvAccessCPP 1.0.100 completed (commit https://github.com/epics-base/pvAccessCPP/commit/6a0c4f85bf by @rerpha)

AppVeyorBot commented 7 months ago

:white_check_mark: Build pvAccessCPP 1.0.101 completed (commit https://github.com/epics-base/pvAccessCPP/commit/84f932cae9 by @rerpha)

AppVeyorBot commented 7 months ago

:white_check_mark: Build pvAccessCPP 1.0.102 completed (commit https://github.com/epics-base/pvAccessCPP/commit/a9eb144842 by @rerpha)

mdavidsaver commented 6 months ago

I don't know if line 363 (the default case) was a bug as i could never get it to run.

That default case should be impossible so long as the switch is consistent with the string passed to getopt(). imo. any inconsistency should be an error. I usually combine default and '?' though.

Maybe there's a good reason that pvget doesn't have this line but the other tools do, please let me know!

I guess you are referring to caget?

It think it is a bit of a judgement call whether PVs is an error with pvget. With pvmonitor I think this should be.

Is it worth changing behavior at this point?

rerpha commented 6 months ago

Maybe there's a good reason that pvget doesn't have this line but the other tools do, please let me know!

I guess you are referring to caget?

It think it is a bit of a judgement call whether PVs is an error with pvget. With pvmonitor I think this should be.

Is it worth changing behavior at this point?

by other tools yes caget, but also pvput, pvinfo, pvmonitor all seem to give the "No pv name(s) specified. ('pvXXXX -h' for help.)" message - just thinking for consistency among the pv* utils it might be nice.

AppVeyorBot commented 3 months ago

:white_check_mark: Build pvAccessCPP 1.0.111 completed (commit https://github.com/epics-base/pvAccessCPP/commit/ef35bf3698 by @rerpha)