epics-base / pvDataCPP

pvDataCPP is an EPICS V4 C++ module
https://epics-base.github.io/pvDataCPP/
Other
6 stars 16 forks source link

set SHRLIB_VERSION for libpvData.so #18

Closed mdavidsaver closed 8 years ago

mdavidsaver commented 8 years ago

Include the module version in the SONAME ("libpvData.so.5.0" atm.). pvData_LIBS is already being set correctly w/ libCom. Others are added by Base/gcc.

$ readelf -d lib/linux-x86_64-debug/libpvData.so |egrep 'NEEDED|SONAME' 0x0000000000000001 (NEEDED) Shared library: [libCom.so.3.16.0] 0x0000000000000001 (NEEDED) Shared library: [libpthread.so.0] 0x0000000000000001 (NEEDED) Shared library: [libreadline.so.6] 0x0000000000000001 (NEEDED) Shared library: [librt.so.1] 0x0000000000000001 (NEEDED) Shared library: [libdl.so.2] 0x0000000000000001 (NEEDED) Shared library: [libstdc++.so.6] 0x0000000000000001 (NEEDED) Shared library: [libm.so.6] 0x0000000000000001 (NEEDED) Shared library: [libgcc_s.so.1] 0x0000000000000001 (NEEDED) Shared library: [libc.so.6] 0x000000000000000e (SONAME) Library soname: [libpvData.so.5.0]

mdavidsaver commented 8 years ago

I've just put the definition of SHRLIB_VERSION in CONFIG_SITE.

anjohnson commented 8 years ago

I would much prefer that SHRLIB_VERSION be set in the Makefile that generates the library, not buried up in the module configuration file. That way a different library built by in the same module could have a different version number (or no version number at all in the case of a test library), and the version number itself is also slightly more visible to the maintainers, so they're more likely to remember to update it.

ralphlange commented 8 years ago

+1 for setting it in the Makefile

mdavidsaver commented 8 years ago

moved