search

epics-base / pvDataCPP

pvDataCPP is an EPICS V4 C++ module
https://epics-base.github.io/pvDataCPP/
Other
6 stars 16 forks source link

pv/ sub-directories #19

Closed mdavidsaver closed 8 years ago

mdavidsaver commented 8 years ago

A demonstration of what I intend with #15. All header files not currently residing in a directory named 'pv' are moved for their current directory to a sub-directory named 'pv'. Makefiles and a few #includes in .cpp are adjusted accordingly.

dhickin commented 8 years ago

See comments in #15.

I'll wait until we have a group decision on that before I merge or close it.

mdavidsaver commented 8 years ago

@mrkraimer you mentioned this morning that you have made similar changes. Can you either publish them, or comment on whether they are substantially different from those of this branch?

anjohnson commented 8 years ago

@mdavidsaver I suspect Marty was referring to equivalent changes in the exampleCPP and pvDatabaseCPP modules.

mrkraimer commented 8 years ago

On 01/26/2016 03:13 PM, mdavidsaver wrote:

@mrkraimer https://github.com/mrkraimer you mentioned this morning that you have made similar changes. Can you either publish them, or comment on whether they are substantially different from those of this branch?

The two projects were:

1) pvDatabaseCPP - This is now merged into master branch of epics-base 2) exampleCPP - pull request #4 has been created. Check Failed. I will look for problem.

— Reply to this email directly or view it on GitHub https://github.com/epics-base/pvDataCPP/pull/19#issuecomment-175206210.

dhickin commented 8 years ago

Pull request OK, but conflicts after merging #17. Rebased, fixed a commit log typo in the process and pushed. Closing - no need to merge.