search

epics-base / pvaClientCPP

pvaClientCPP is an EPICS V4 C++ module
http://epics-pvdata.sourceforge.net/index.html
Other
2 stars 8 forks source link

Compiler warnings #31

Closed anjohnson closed 8 years ago

anjohnson commented 8 years ago

Marty, please fix these, they generate more build warnings than all the other modules put together:

../pv/pvaClient.h:1351: warning: type attributes are honored only at type definition
../pv/pvaClient.h:1360: warning: 'class epics::pvaClient::PvaClientMonitor' has virtual functions but non-virtual destructor
../pv/pvaClient.h:1484: warning: type attributes are honored only at type definition
../pv/pvaClient.h:1493: warning: 'class epics::pvaClient::PvaClientRPC' has virtual functions but non-virtual destructor

Thanks - Andrew

anjohnson commented 8 years ago

Hi Marty,

Your final comit in #30 was almost certainly necessary for static builds, but wasn't going to fix this issue.

The warnings from lines 1351 and 1484 of the pvaClient.h header say remove the keyword epicsShareClass from those two lines; that keyword should only be used on the full class definition. The warnings from lines 1360 and 1493 are telling you to make those two classes' destructors virtual.