search

epics-base / pvaClientCPP

pvaClientCPP is an EPICS V4 C++ module
http://epics-pvdata.sourceforge.net/index.html
Other
2 stars 8 forks source link

Fix for Issue #31 #34

Closed anjohnson closed 8 years ago

anjohnson commented 8 years ago

Fix verbose warning messages I was seeing from one of my builds.

anjohnson commented 8 years ago

retest this please

mrkraimer commented 8 years ago

I am going to close this pull request. I think I have fixed what this pull request attempts but put the epicsShareClass in the source file. I think this is where it belongs because that is where the class is actually implemented. I also made some changes to fix warnings showing up on vxWorks.

anjohnson commented 8 years ago

I'm still getting the two warnings below, because you haven't removed the extraneous epicsShareClass keywords from the two declarations in the pvaClient.h header file, see my commit 0e9c61a.

../pv/pvaClient.h:1398: warning: type attributes are honored only at type definition
../pv/pvaClient.h:1535: warning: type attributes are honored only at type definition

I think the reason that I'm seeing those warnings but the Jenkins build is not is because I'm building V4 against Base-3.15 whereas the APS Jenkins build is against Base-3.14, and the keyword macros in shareLib.h have changed slightly.

mrkraimer commented 8 years ago

On 07/20/2016 01:33 PM, Andrew Johnson wrote:

I'm still getting the two warnings below, because you haven't removed the extraneous |epicsShareClass| keywords from the two declarations in the pvaClient.h header file, see my commit 0e9c61a https://github.com/epics-base/pvaClientCPP/commit/0e9c61a37912c326b1dcd867c4bee973225c45c4.

|../pv/pvaClient.h:1398: warning: type attributes are honored only at type definition ../pv/pvaClient.h:1535: warning: type attributes are honored only at type definition |

I think the reason that I'm seeing those warnings but the Jenkins build is not is because I'm building V4 against Base-3.15 whereas the APS Jenkins build is against Base-3.14, and the keyword macros in shareLib.h have changed slightly.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/epics-base/pvaClientCPP/pull/34#issuecomment-234022133, or mute the thread https://github.com/notifications/unsubscribe-auth/AF1Q1s6P7PhoI3z3hfkqehJz0HEOP6dyks5qXlvygaJpZM4JQQzd.

I am creating a pull request to fix this.