search

epics-base / pvaClientCPP

pvaClientCPP is an EPICS V4 C++ module
http://epics-pvdata.sourceforge.net/index.html
Other
2 stars 8 forks source link

Revert "Minor changes" #49

Closed mrkraimer closed 6 years ago

mrkraimer commented 6 years ago

Reverts epics-base/pvaClientCPP#48

anjohnson commented 6 years ago

Thanks Marty.

mrkraimer commented 6 years ago

On 01/09/2018 04:01 PM, Andrew Johnson wrote:

Thanks Marty.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/epics-base/pvaClientCPP/pull/49#issuecomment-356412697, or mute the thread https://github.com/notifications/unsubscribe-auth/AF1Q1ifdr1Qp7qvgzCE8O-fp4Kt94tWkks5tI9OUgaJpZM4RYYRM.

I do plan to start working on making the minor changes I made before. But  the create method that pvaPy uses will be implemented. I will check to see if it is easy to change pvaPy so that it does not call this method. If the answer is yes I will make the method deprecated.

ralphlange commented 6 years ago

FWIW: Incompatible changes in a public API are never "minor" - by definition. Let's please try to be comprehensive and consistent in labeling things.