epics-containers / ec-helm-charts

A set of shared helm charts for domain services and IOC instances
Apache License 2.0
1 stars 1 forks source link

Add missing globals dictionary to schema #40

Open marcelldls opened 4 days ago

marcelldls commented 4 days ago

For the globals dictionary, this still allows additionalProperties to be added - which means that you could accidentally include "enable" rather than "enabled" for example. However, since globals are passed to subcharts - there may be legitimate arbitrary globals passed that we have not considered. Im open to adding "additionalProperties": false because it would give a better hint during validation, but opting out of CI would be needed for adding arbitrary globals