search

epics-containers / edge-containers-cli

command line shortcuts for epics containers developers
Apache License 2.0
3 stars 1 forks source link

make ec list and instances output consistant with ps #112

Closed marcelldls closed 6 months ago

marcelldls commented 6 months ago

Currently we get

(.venv) [esq51579@pc0146 edge-containers-cli]$ ec ps
| name             | version  | running | restarts | deployed            |
|------------------|----------|---------|----------|---------------------|
| epics-opis       | 2024.2.9 | true    | 0        | 2024-02-28 15:44:42 |
| bl01c-di-dcam-01 | 2024.2.4 | true    | 0        | 2024-03-13 13:45:38 |
| bl01c-di-dcam-02 | 2024.2.5 | true    | 0        | 2024-03-13 13:46:03 |
| bl01c-ea-test-01 | 2024.2.1 | true    | 0        | 2024-03-13 13:47:03 |
| bl01c-mo-ioc-01  | 2024.3.1 | true    | 0        | 2024-03-04 12:17:03 |
[esq51579@pc0146 WIP]$ ec list
Available services:                Latest instance:
bl01c-di-dcam-01                   2024.2.4
bl01c-di-dcam-02                   2024.2.5
bl01c-ea-test-01                   2023.3.2
bl01c-ea-test-02                   2024.2.3
bl01c-ea-test-03                   2023.3.2
bl01c-mo-ioc-01                    2024.3.1
epics-opis                         2024.2.9
epics-pvcs                         2023.3.2
[esq51579@pc0146 WIP]$ ec instances bl01c-di-dcam-01
Available instances for bl01c-di-dcam-01:
2024.2.4  2023.3.2

This PR makes the output more consistant

(.venv) [esq51579@pc0146 edge-containers-cli]$ ec ps
| name             | version  | running | restarts | deployed            |
|------------------|----------|---------|----------|---------------------|
| epics-opis       | 2024.2.9 | true    | 0        | 2024-02-28 15:44:42 |
| bl01c-di-dcam-01 | 2024.2.4 | true    | 0        | 2024-03-13 13:45:38 |
| bl01c-di-dcam-02 | 2024.2.5 | true    | 0        | 2024-03-13 13:46:03 |
| bl01c-ea-test-01 | 2024.2.1 | true    | 0        | 2024-03-13 13:47:03 |
| bl01c-mo-ioc-01  | 2024.3.1 | true    | 0        | 2024-03-04 12:17:03 |
(.venv) [esq51579@pc0146 edge-containers-cli]$ ec list
| name             | version  |
|------------------|----------|
| bl01c-di-dcam-01 | 2024.2.4 |
| bl01c-di-dcam-02 | 2024.2.5 |
| bl01c-ea-test-01 | 2024.2.1 |
| bl01c-ea-test-02 | 2024.2.3 |
| bl01c-ea-test-03 | 2024.2.7 |
| bl01c-mo-ioc-01  | 2024.3.1 |
| epics-opis       | 2024.2.9 |
| epics-pvcs       | 2024.2.1 |
(.venv) [esq51579@pc0146 edge-containers-cli]$ ec instances bl01c-ea-test-01
| version  |
|----------|
| 2024.2.1 |
| 2023.3.2 |
This format is interpretable as markdown name version running restarts deployed
epics-opis 2024.2.9 true 0 2024-02-28 15:44:42
bl01c-di-dcam-01 2024.2.4 true 0 2024-03-13 13:45:38
bl01c-di-dcam-02 2024.2.5 true 0 2024-03-13 13:46:03
bl01c-ea-test-01 2024.2.1 true 0 2024-03-13 13:47:03
bl01c-mo-ioc-01 2024.3.1 true 0 2024-03-04 12:17:03
codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 79.21%. Comparing base (6f7c3a6) to head (dc77f7a).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #112 +/- ## ========================================== + Coverage 79.14% 79.21% +0.06% ========================================== Files 14 14 Lines 892 890 -2 ========================================== - Hits 706 705 -1 + Misses 186 185 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marcelldls commented 6 months ago

I wonder if it would be useful for regression testing for all cli commands to introduce comparing the expected output (rather than just successfully running the shell commands). Thoughts?