Deploy by name - Githubissues

epics-containers / edge-containers-cli

command line shortcuts for epics containers developers

Apache License 2.0

3 stars 1 forks source link

Deploy by name #129

Closed marcelldls closed 1 month ago

marcelldls commented 1 month ago

This PR resolves #114 by doing a template or deploy-local using chart name (as per https://v2.helm.sh/docs/developing_charts/#charts-and-versioning) rather than *.tgz. The information is extracted from Chart.yaml

This is tested using ec template and checking for expected changes against:

Changes to the shared charts dependency (this is picked up by helm package -u)
Changes to ioc-instance versions (Chart.yaml) and changes to chart config (ioc.yaml)

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.83%. Comparing base (cd07633) to head (526e1a4).

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #129 +/- ## ========================================== + Coverage 86.78% 86.83% +0.04% ========================================== Files 14 14 Lines 802 805 +3 ========================================== + Hits 696 699 +3 Misses 106 106 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gilesknap commented 1 month ago

This looks good. I note that the tgz name includes the version and that would be different for each local deploy and therefore it was non-deterministic which of the set of current tgzs would get deployed. Thus I'm pretty sure this covers what I was seeing in the issue.

Thanks.

Ready to merge I believe.