search

epics-containers / edge-containers-cli

command line shortcuts for epics containers developers
Apache License 2.0
3 stars 1 forks source link

Create monitor window for running IOCs #135

Closed OCopping closed 4 months ago

OCopping commented 4 months ago

This PR is to make a TUI to display all currently running IOCs on kubernetes. To run type ec monitor. Fixes #131

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 55.03597% with 125 lines in your changes are missing coverage. Please review.

Project coverage is 77.61%. Comparing base (4950275) to head (330088b). Report is 1 commits behind head on main.

Files Patch % Lines
src/edge_containers_cli/cmds/monitor.py 33.56% 97 Missing :warning:
src/edge_containers_cli/cmds/commands.py 54.90% 23 Missing :warning:
src/edge_containers_cli/cmds/cli.py 84.84% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #135 +/- ## ========================================== - Coverage 86.92% 77.61% -9.32% ========================================== Files 14 16 +2 Lines 811 983 +172 ========================================== + Hits 705 763 +58 - Misses 106 220 +114 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gilesknap commented 4 months ago

This looks good and I like the integration into k8s_commands and local_commands.

I'd quite like the layout to be more compact - we are going to need to see lots of IOCs because they are going to be fine grained, is it possible to dynamically choose the column widths based on content like the text based output does?

If you want to try some beamlines with more iocs for a better view I can get you added to BL20J and BL45P.

Great start.

gilesknap commented 4 months ago

I see you have scrolling working. And resizing to the terminal size.

Looks good. But is sluggish. I figure we could go with a very low update rate - perhaps .5 Hz would do.

gilesknap commented 4 months ago

We can retire this PR now as Ollie is working on coninute-tui branch