epics-containers / edge-containers-cli

command line shortcuts for epics containers developers
Apache License 2.0
3 stars 1 forks source link

Refactor #138

Closed gilesknap closed 1 month ago

gilesknap commented 1 month ago

This refactors the code into a fashion that is more appropriate for adding an interactive TUI.

Frankly, I wrote this inside out initially and this is how it should have been done. The unit tests were a great help in making these changes.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 70.77922% with 45 lines in your changes are missing coverage. Please review.

Project coverage is 77.61%. Comparing base (98ca2e2) to head (fb790a6).

Files Patch % Lines
src/edge_containers_cli/cmds/commands.py 54.90% 23 Missing :warning:
src/edge_containers_cli/cmds/monitor.py 29.16% 17 Missing :warning:
src/edge_containers_cli/cmds/cli.py 83.87% 5 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## create_monitor #138 +/- ## ================================================== - Coverage 79.14% 77.61% -1.53% ================================================== Files 15 16 +1 Lines 954 983 +29 ================================================== + Hits 755 763 +8 - Misses 199 220 +21 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gilesknap commented 1 month ago

@OCopping We have a really good test coverage on this project. Do you know of any way of adding tests for the Monitor code so we can keep that quality bar high?

gilesknap commented 1 month ago

I'm going to merge this and release it - then @OCopping's TUI changes will go on top of main.

gilesknap commented 1 month ago

Ooops merged it into create_monitor. Will now do another PR into main.