search

epics-containers / edge-containers-cli

command line shortcuts for epics containers developers
Apache License 2.0
3 stars 1 forks source link

Add developer container option for deploy-local #148

Closed marcelldls closed 1 month ago

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 71.42857% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 84.05%. Comparing base (11eca91) to head (4514e19).

Files Patch % Lines
src/edge_containers_cli/cmds/helm.py 71.42% 4 Missing :warning:
src/edge_containers_cli/cmds/k8s_commands.py 57.14% 3 Missing :warning:
src/edge_containers_cli/cmds/local_commands.py 80.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #148 +/- ## ========================================== - Coverage 84.69% 84.05% -0.65% ========================================== Files 15 15 Lines 843 859 +16 ========================================== + Hits 714 722 +8 - Misses 129 137 +8 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

marcelldls commented 1 month ago

We have decided to fix the issue by making it clearer in the services template (by adding an example as a comment) that the image can be overridden to a developer container in the service's values