search

epics-containers / edge-containers-cli

command line shortcuts for epics containers developers
Apache License 2.0
3 stars 1 forks source link

Using local folder as deploy argument #59

Closed marcelldls closed 11 months ago

marcelldls commented 11 months ago

Resolves #56 but have only applied it to ec ioc deploy, could be useful for other commands

codecov-commenter commented 11 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (c25ffd2) 85.51% compared to head (4422c8a) 85.31%.

Files Patch % Lines
src/epics_containers_cli/utils.py 57.14% 3 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #59 +/- ## ========================================== - Coverage 85.51% 85.31% -0.20% ========================================== Files 17 17 Lines 842 851 +9 ========================================== + Hits 720 726 +6 - Misses 122 125 +3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gilesknap commented 11 months ago

@marcelldls one thing you could add for completeness is a unit test to verify this usecase.

make a copy of https://github.com/epics-containers/epics-containers-cli/blob/main/tests/test_ioc.py#L27-L33 and give it some different YAML to use - similar to https://github.com/epics-containers/epics-containers-cli/blob/main/tests/data/ioc.yaml#L33-L39