epics-containers / ibek-support

ibek definitions
Apache License 2.0
1 stars 9 forks source link

install.sh missing dependency checks #32

Open gilesknap opened 7 months ago

gilesknap commented 7 months ago

install.sh is supposed to be the recipe for building a support module in the container environment.

However it is up to the Dockerfile to build dependencies before calling install.sh for a given module. This is fine, except that the install.sh should be able to give the developer information on the dependencies and check that they have been supplied.

I suggest:

ibek support check-dependencies Asyn busy ADCore

for example. How to check? We could just do it off of macros in global configure RELEASE or we could get more sophisticated and check that the module has actually been built. @coretl @GDYendell looking for suggestions of how to do this in a clean fashion.

This helps avoid unpicking build errors due to missing dependencies.

GDYendell commented 7 months ago

Would checking for /epics/support/<module> be sufficient?

gilesknap commented 7 months ago

Tom and I discussed this morning. The checks will be:-