epics-containers / ibek

IOC Builder for EPICS and Kubernetes
https://epics-containers.github.io/ibek
Apache License 2.0
11 stars 5 forks source link

get rid of 'db'subst' and 'ioc.substitution' + make default generate output in /tmp #128

Closed gilesknap closed 11 months ago

gilesknap commented 11 months ago

The substitution file should always be called ioc.subst so ibek generate looks for :

and generates from yaml:

I believe this has been fixed throughout ibek and the scripts that use it but there is at least one place this is still wrong:

def generate(
    instance: Path = typer.Argument(
        ..., help="The filepath to the ioc instance entity file"
    ),
    definitions: List[Path] = typer.Argument(
        ..., help="The filepath to a support module definition file"
    ),
    out: Path = typer.Option(
        default="config/st.cmd",
        help="Path to output startup script",
    ),
    db_out: Path = typer.Option(
        default="config/db.subst",
        help="Path to output database expansion shell script",
    ),
):

defaults SHOULD be

gilesknap commented 11 months ago

done in f7d82deb08596c5a7761eeba70f11ee123a1f5da