epics-containers / ibek

IOC Builder for EPICS and Kubernetes
https://epics-containers.github.io/ibek
Apache License 2.0
10 stars 4 forks source link

locations for pvi bob etc. files. #129

Open gilesknap opened 8 months ago

gilesknap commented 8 months ago

An update from today's meeting.

Essentially:

This all means that the /epics/opis folder can be shared over HTTP as is and no rsync required

image

gilesknap commented 8 months ago

Re that long discussion on the argument to pass.

It in fact needs to be on the start.sh script so start.sh --dev would be OK. But only if we set the bob files to read only so that you get some indication that you forgot this option.

gilesknap commented 8 months ago

@GDYendell would you like to work together next week. To finalise this and get your PR merged - we might as well include the templates as well so that we can say ibek / pvi integration is comple.

GDYendell commented 8 months ago

But only if we set the bob files to read only so that you get some indication that you forgot this option.

I think this is critical whatever the API is.

would you like to work together next week

Yep!

GDYendell commented 8 months ago

If we are taking the bob section out of support.yaml so that it is not set in stone at container build time, does that mean the config needs to go into the ioc.yaml so that the ibek add-bob ... calls can be included in the generated start.sh?

coretl commented 8 months ago

I think there's 2 parts to this:

  1. We need the ability for ibek add-bob... to be run either manually in start,sh, or as a section in ioc.yaml.
  2. If we are using ioc.yaml we also need the ability to associate one of these bobs as the one to be linked as an index, in preference to the pvi generated one

I suspect that most people will not be using manually generated bob files at the IOC level, so maybe they will be happy with the autogenerated pvi ones and this will be a non-issue? Either way, as we don't have clear requirements, I suggest we defer this for now.

gilesknap commented 8 months ago

Isn't it pretty much a case of lifting the pvi:opi section from support schema and putting it in ioc schema. The code that reads the opi bits still runs at runtime anyway.

If it is easy to do then let's do it now. Then we have a custom bob mechanism that people can try if needed.

coretl commented 8 months ago

It's not quite the same, as the ibek support yaml structure allows us to define a bob file per definition, while if we do a straight copy of that into the ioc yaml we would have to do this per entity. This means we would have to specify the same bob file for every motor on the beamline for instance. I think we should strip it out for now, and put it back in when we have a use case.

GDYendell commented 8 months ago

Maybe we need some way to do additional definition config in ioc.yaml so that it doesn't have to be duplicated for every entity. I agree, let's just use the pvi bobs for now.

gilesknap commented 8 months ago

:+1:

gilesknap commented 2 weeks ago

So I believe this is all resolved now.

@GDYendell do you agree this can be closed?

GDYendell commented 2 weeks ago

I think so, although a lot of our ideas above are not what we have now. Is what we ended up doing summarised nicely somewhere?

gilesknap commented 2 weeks ago

Probably not. I'll leave this open as a 'document pvi / ibek integration'