search

epics-containers / ibek

IOC Builder for EPICS and Kubernetes
https://epics-containers.github.io/ibek
Apache License 2.0
10 stars 4 forks source link

Realistic examples in system tests #152

Closed gilesknap closed 7 months ago

gilesknap commented 7 months ago

@GDYendell you might be interested in this as it hopefully fixes an issue you raised with the ibek system tests. But don't spend lots of time on it - the tests pass and the coverage is good (still need to add tests for the the subcommands that call shell - thats next).

codecov-commenter commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3818519) 70.62% compared to head (858582d) 70.51%. Report is 7 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #152 +/- ## ========================================== - Coverage 70.62% 70.51% -0.11% ========================================== Files 17 17 Lines 926 926 ========================================== - Hits 654 653 -1 - Misses 272 273 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

gilesknap commented 7 months ago

@coretl you might be interested to know I have added checks for jinja escaping. Does this cover what you asked me about recently?

https://github.com/epics-containers/ibek/blob/858582d8a4242548273e9c051514b1aaddf3fbe6/tests/samples/iocs/ibek-mo-ioc-01.yaml#L26-L32

https://github.com/epics-containers/ibek/blob/858582d8a4242548273e9c051514b1aaddf3fbe6/tests/samples/support/asyn.ibek.support.yaml#L110-L121

https://github.com/epics-containers/ibek/blob/858582d8a4242548273e9c051514b1aaddf3fbe6/tests/samples/support/motorSim.ibek.support.yaml#L34-L44

See the expected results in https://github.com/epics-containers/ibek/tree/dev/tests/samples/outputs