bug: compose/enviroment.sh does not work for podman

epics-containers / ioc-template

A copier template for creating generic IOC repositories

Apache License 2.0

0 stars 1 forks source link

Closed gilesknap closed 3 weeks ago

gilesknap commented 2 months ago

That is because it sets an alias docker=podman and then tries to use it.

Fix:

still set the alias
but also set an env variable docker=docker or docker=podman
change command line that creates the network to $docker from docker (same as we already do in template/build)

ALSO

alias ec='docker compose' should be alias dc='docker compose'

gilesknap commented 2 months ago

Propogate this change to ioc-adsimdetector and release as 4.0.1

marcelldls commented 1 month ago

I believe works on our diamond workstations because by default we have alias expansion enabled:

[esq51579@pc0146 ~]$ [ "$(shopt -p expand_aliases)" == "shopt -s expand_aliases" ] && echo "Enabled" || echo "Disabled"
Enabled

However it failed on a training laptop, we should probably not rely on alias expansion in a script