search

epics-containers / ioc-template

A copier template for creating generic IOC repositories
Apache License 2.0
0 stars 1 forks source link

Enable qsrv and pvxs to create PVA PVs #7

Closed GDYendell closed 3 months ago

GDYendell commented 4 months ago

Would it be possible to instantiate an instance of the template to make sure it works, like the python copier template does? It would be good to check that install scripts I have added calls for exist in ibek-support.

gilesknap commented 4 months ago

Would it be possible to instantiate an instance of the template to make sure it works, like the python copier template does? It would be good to check that install scripts I have added calls for exist in ibek-support.

Yes we should do this. I just have not got around to it.

gilesknap commented 4 months ago

@GDYendell I have one question on these PRs.

Will qserv ever be installed separately to pvxs? It's just making the Dockerfile longer and it feels odd that the qserv install.sh takes no version number.

The alternative is to just add the lib and dbd in the pvxs install.sh - and it can be done without adding any extra lines to that file. Less is more, right?

Other than that we are all good.

GDYendell commented 4 months ago

Sorry I commented here.

I split these into two install scripts as you could possibly want qsrv to make PVA PVs for all your records, but not pvxs to create PVA PVs from the info tags.

I think it makes sense to split them but don't feel strongly about it. Any thoughts @coretl ?

coretl commented 4 months ago

qsrv.dbd is the old one, pvxsIoc.dbd completely replaces it (including making PVA PVs from info tags), so we never need qsrv.dbd. I suggest you get rid of the qsrv/install.sh here and in ibek-support

GDYendell commented 3 months ago

Updated to only use pvxs and it still works the same.