epics-extensions / vscode-epics

VS Code colorization for EPICS database, templates and substitution files
MIT License
14 stars 6 forks source link

Added coloring for *.vdb files #23

Closed TimGuiteDiamond closed 4 years ago

TimGuiteDiamond commented 4 years ago

VDB files are essentially DB files with extra comments at the end for telling the VDCT program where to position records on screen.

The extension intereprets and colors the VDB files correctly as is.

TimGuiteDiamond commented 4 years ago

We just became aware of this extension at Diamond Light Source and thought I would try to contribute as it works really well already! We use VDCT to help us create databases and there is no obvious reason why they can't share the colouring of *.db files.

This is a very minor change but let me know what you think and if you are looking for more contributions in the future.

I don't know of any other tools for EPICS autocomplete so this is a big step forwards :)

NSenaud commented 4 years ago

Hi @TimGuiteDiamond, thank you for your contribution!

I launched this project years ago but I am no longer using EPICS actually, so I can merge your PR but not really testing it. Could you take a look @vnadot ?

We'll take a look in the following days to move this repository to a Github org, which will be a better place than my personal profile to further develop and maintain this extension. And I think any future contribution will be more than welcome @TimGuiteDiamond :)

TimGuiteDiamond commented 4 years ago

Ah makes sense! I have tested it with our *.vdb files here and it seems to work fine, would you like me to try and add some proper tests?

Yea if you're not using it directly any more then I'm sure it could happily live somewhere else:

Just suggestions :+1:

NSenaud commented 4 years ago

I don't think any proper tests are required, I just think it is just better if someone else can double-check there is no problem. Given the limited scope of the change I am tempted to merge it without testing it but, you know, it doesn't always end well :) @vnadot is unavailable right now (he is the de facto maintainer of the extension for the last 2 years and a half), but I expect he will be able to test and merge the PR is the coming days, and publish an update.

I don't know if the repo would fit in the EPICS extensions' org, but I guess it would make sense, and gave the extension a lot of visibility. I was working at CEA Saclay/Irfu when I began this project, and @vnadot still does, it would also make sens to create an organization with that name. I you/Diamond become significant contributors I guess it would also make sense to move it there.

I will discuss the options with @vnadot in the coming week, I don't think I legit to take this decision by myself anymore, we will fix the issue and get this PR merged :smile:

TimGuiteDiamond commented 4 years ago

Ok great! Yea perhaps if there were an EPICS tools organisation or something it would work better there but I didn't find anything in my brief search, will let you know if if do! Would be quite happy if it were in a CEA organisation too :smile: Thanks for replying anyway and getting this moving!