search

epics-modules / autosave

APS BCDA synApps module: autosave
https://epics-modules.github.io/autosave/
Other
8 stars 31 forks source link

Fixes for autosave managed NFS mounts #62

Open JJL772 opened 2 months ago

JJL772 commented 2 months ago

These changes allow for autosave to manage mounts where the exported path is not the same as the mount point.

I've tested this on a hard IOC running on a mvme-3100 CPU. The original behavior should be retained as well.

anjohnson commented 2 months ago

I'm not the maintainer of this module but I can and will approve the PR to be run.

The thing that concerns me slightly about it is the printing of messages when a remount occurs and succeeds. The previous code appears to have been silent when successful, so users who were monitoring the IOC console might think that this change has caused additional NFS issues, or they might just not want to know when it worked properly. I understand the desire to be able to enable such messages for debugging and monitoring, but I wonder if the maintainers might prefer to keep the old behavior, maybe condition the prints on some debug or verbosity setting?

JJL772 commented 2 months ago

Good catch, I didn't even notice the duplicated printfs. I'm going to leave the "Successfully remounted ..." message alone, as it's a good indicator that autosave was conducting a remount.