epics-modules / devlib2

Helper library for memory mapped bus access
http://epics-modules.github.io/devlib2/
Other
4 stars 8 forks source link

Quite some time since last tag #16

Closed agaget closed 10 months ago

agaget commented 10 months ago

Hello, I notice that the last tag was long time ago (will celebrate its 4 years in next April). I don't know the politics of tags but for example the mrfioc2 doesn't work with the last tag.

I can't exactly remember why, I just have the note saying that I needed this patch for it to work : https://github.com/epics-modules/devlib2/commit/0d41740772465d4409be38e6bf998f0a901f8b04.patch

Thanks for your consideration

jerzyjamroz commented 10 months ago

@agaget In the case of mrfioc2, the tag is added once there is a certain stage achieved, or upon a certain request (e.g. via issue). If the last mrfioc2 tag does not work for you then open the issue in the mrfioc2 repo with the relevant log and description. It works fine with our test setup.

In the case of the devlib2 I use 2.11 up to now. I do not have time for it now but If you test the master branch and ensure it works fine, I can release 2.12 for you, just add info about the improvements it would add as well.

agaget commented 10 months ago

Hello, My first sentence was not clear, I wasn't talking about the mrfioc2 tag, that is just fine for me, just the fact that it wasn't working with the 2.11.

I will test the 2.11 again but I think the problem was the missing include #include <shareLib.h>. That way I will test also your new naming convention.

Keep in touch when it's done

agaget commented 10 months ago

I can't compile devlib2 2.11 with epics-7.0.7 , I have the following issues

make -C ./vmeApp install
make[1] : on entre dans le répertoire « /home/agaget/devTitan/devlib2/vmeApp »
make -C O.linux-x86_64 -f ../Makefile TOP=../.. \
    T_A=linux-x86_64 install
make[2] : on entre dans le répertoire « /home/agaget/devTitan/devlib2/vmeApp/O.linux-x86_64 »
cc  -D_GNU_SOURCE -D_DEFAULT_SOURCE        -DUSE_TYPED_RSET -I../../common  -D_X86_64_ -DUNIX  -Dlinux      -O3   -Wall -Werror-implicit-function-declaration     -fdiagnostics-color=always -mtune=generic     -m64  -fPIC -I. -I../O.Common -I. -I. -I../os/default -I.. -I../../include/compiler/gcc -I../../include/os/Linux -I../../include -I/nix/store/3jdcplbpdj2177csm7nbw3prjlaq1bdn-epics-base-7.0.7/include/compiler/gcc -I/nix/store/3jdcplbpdj2177csm7nbw3prjlaq1bdn-epics-base-7.0.7/include/os/Linux -I/nix/store/3jdcplbpdj2177csm7nbw3prjlaq1bdn-epics-base-7.0.7/include        -MM -MF devlib_compat.d  ../devlib_compat.c
cc  -D_GNU_SOURCE -D_DEFAULT_SOURCE        -DUSE_TYPED_RSET -I../../common  -D_X86_64_ -DUNIX  -Dlinux      -O3   -Wall -Werror-implicit-function-declaration     -fdiagnostics-color=always -mtune=generic     -m64  -fPIC -I. -I../O.Common -I. -I. -I../os/default -I.. -I../../include/compiler/gcc -I../../include/os/Linux -I../../include -I/nix/store/3jdcplbpdj2177csm7nbw3prjlaq1bdn-epics-base-7.0.7/include/compiler/gcc -I/nix/store/3jdcplbpdj2177csm7nbw3prjlaq1bdn-epics-base-7.0.7/include/os/Linux -I/nix/store/3jdcplbpdj2177csm7nbw3prjlaq1bdn-epics-base-7.0.7/include        -MM -MF vmesh.d  ../vmesh.c
cc  -D_GNU_SOURCE -D_DEFAULT_SOURCE        -DUSE_TYPED_RSET -I../../common  -D_X86_64_ -DUNIX  -Dlinux      -O3   -Wall -Werror-implicit-function-declaration     -fdiagnostics-color=always -mtune=generic     -m64  -fPIC -I. -I../O.Common -I. -I. -I../os/default -I.. -I../../include/compiler/gcc -I../../include/os/Linux -I../../include -I/nix/store/3jdcplbpdj2177csm7nbw3prjlaq1bdn-epics-base-7.0.7/include/compiler/gcc -I/nix/store/3jdcplbpdj2177csm7nbw3prjlaq1bdn-epics-base-7.0.7/include/os/Linux -I/nix/store/3jdcplbpdj2177csm7nbw3prjlaq1bdn-epics-base-7.0.7/include        -MM -MF devcsr.d  ../devcsr.c
Installing generic include file ../../include/devcsr.h
cc  -D_GNU_SOURCE -D_DEFAULT_SOURCE        -DUSE_TYPED_RSET -I../../common  -D_X86_64_ -DUNIX  -Dlinux      -O3   -Wall -Werror-implicit-function-declaration     -fdiagnostics-color=always -mtune=generic     -m64  -fPIC -I. -I../O.Common -I. -I. -I../os/default -I.. -I../../include/compiler/gcc -I../../include/os/Linux -I../../include -I/nix/store/3jdcplbpdj2177csm7nbw3prjlaq1bdn-epics-base-7.0.7/include/compiler/gcc -I/nix/store/3jdcplbpdj2177csm7nbw3prjlaq1bdn-epics-base-7.0.7/include/os/Linux -I/nix/store/3jdcplbpdj2177csm7nbw3prjlaq1bdn-epics-base-7.0.7/include        -c ../devcsr.c
Dans le fichier inclus depuis ../devcsr.c:16:
../devcsr.h:84:15: erreur: expected « ; » before « volatile »
   84 | epicsShareFunc
      |               ^
      |               ;
   85 | volatile unsigned char* devCSRProbeSlot(int slot);
      | ~~~~~~~~       
../devcsr.h:114:15: erreur: expected « ; » before « volatile »
  114 | epicsShareFunc
      |               ^
      |               ;

It compiles just fine with the following commit : 0d41740772465d4409be38e6bf998f0a901f8b04

gabrielfedel commented 10 months ago

New release of devlib2 available: https://github.com/epics-modules/devlib2/releases/tag/2.12