search

epics-modules / iocStats

EPICS IOC Status and Control
Other
12 stars 38 forks source link

Should we keep the stringin versions of APPDIR and ST_SCRIPT? #59

Open simon-ess opened 11 months ago

simon-ess commented 11 months ago

We currently keep three records to keep track of the startup script location and the aplication directory, which split the full path into parts (and not necessarily enough for that even...).

Do we need to keep these old record types?

anjohnson commented 11 months ago

Is there support for the lsi (long string input) record type yet? I don't see any, but that record type has been available in 3.15 since 2012. I would recommend using that instead of waveform records for anything which is a string. However the devIocStatsString.c support currently has several more kinds of inputs than the devIocStatsWaveform.c does:

devIocStatsString.c:    {"startup_script_1", statsSScript1, STATIC_TYPE},
devIocStatsString.c:    {"startup_script_2", statsSScript2, STATIC_TYPE},
devIocStatsString.c:    {"bootline_1", statsBootline1, STATIC_TYPE},
devIocStatsString.c:    {"bootline_2", statsBootline2, STATIC_TYPE},
devIocStatsString.c:    {"bootline_3", statsBootline3, STATIC_TYPE},
devIocStatsString.c:    {"bootline_4", statsBootline4, STATIC_TYPE},
devIocStatsString.c:    {"bootline_5", statsBootline5, STATIC_TYPE},
devIocStatsString.c:    {"bootline_6", statsBootline6, STATIC_TYPE},
devIocStatsString.c:    {"bsp_rev", statsBSPRev, STATIC_TYPE},
devIocStatsString.c:    {"kernel_ver", statsKernelVer, STATIC_TYPE},
devIocStatsString.c:    {"epics_ver", statsEPICSVer, STATIC_TYPE},
devIocStatsString.c:    {"engineer", statsEngineer, STATIC_TYPE},
devIocStatsString.c:    {"location", statsLocation, STATIC_TYPE},
devIocStatsString.c:    {"up_time", statsUpTime, STATIC_TYPE},
devIocStatsString.c:    {"hostname", statsHostName, STATIC_TYPE},
devIocStatsString.c:    {"pwd1", statsPwd1, STATIC_TYPE},
devIocStatsString.c:    {"pwd2", statsPwd2, STATIC_TYPE},

devIocStatsWaveform.c:    {"startup_script", statsSScript, STATIC_TYPE},
devIocStatsWaveform.c:    {"bootline", statsBootline, STATIC_TYPE},
devIocStatsWaveform.c:    {"epics_ver", statsEPICSVer, STATIC_TYPE},
devIocStatsWaveform.c:    {"pwd", statsPwd, STATIC_TYPE},

I don't see anything there at all for APPDIR...