epics-modules / ip

APS BCDA synApps module: ip
http://epics-modules.github.io/ip/
Other
3 stars 9 forks source link

Do the op/ui files belong in op/ui/autoconvert? #14

Closed MarkRivers closed 5 years ago

MarkRivers commented 5 years ago

The edl files are in op/edl/autoconvert and the opi files are in op/opi/autoconvert. Should the ui files be in op/ui/autoconvert, or are these manually tweaked? I would like to add the op/Makefile so we can automatically convert in the future when new files are added or medm files are edited. But first I want to have the ui files in the correct location.

prjemian commented 5 years ago

The manually-tweaked files are in op/ui while op/Makefile only updates op/ui/autoconvert (from op/adl)

MarkRivers commented 5 years ago

The manually-tweaked files are in op/ui while op/Makefile only updates op/ui/autoconvert (from op/adl)

I understand that. That would imply that all ~100 files in op/ui were manually tweaked, and there no autoconverted files because the autoconvert directory is empty. I find this highly doubtful. I have done a "git log" on a number of the files, and the last commit for each was Sept. 11, 2014 with the same commit message.

Engbretson commented 5 years ago

Pete’s answer is the convention (from a recent group meeting) that bcda would like to be consistent everywhere so that the scripts which create/autoconvert the opi’s and ui’s will always be up to date with the adl files, but if someone tweaks any of these files, they don’t get trashed by an adl update. So the path hierarchy of where to look is known.

Which implies that across the board, only adl files should be in the expected locations and everything else should now be living in one of the autoconvert locations. There should never be anything in ui or edl since that already implies that there are not consistent with adl.

From: Mark Rivers notifications@github.com Sent: Friday, October 5, 2018 9:12 AM To: epics-modules/ip ip@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [epics-modules/ip] Do the op/ui files belong in op/ui/autoconvert? (#14)

The manually-tweaked files are in op/ui while op/Makefile only updates op/ui/autoconvert (from op/adl)

I understand that. That would imply that all ~100 files in op/ui were manually tweaked, and there no autoconverted files because the autoconvert directory is empty. I find this highly doubtful. I have done a "git log" on a number of the files, and the last commit for each was Sept. 11, 2014 with the same commit message.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/epics-modules/ip/issues/14#issuecomment-427379672, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AM66i4Jy41p4V_R7FS9Yw24sWDi2NTn3ks5uh2i2gaJpZM4XKORa.

timmmooney commented 5 years ago

I agree. I'm going to move all the ui files in op/ui to op/ui/autoconvert.

Tim Mooney (mooney@aps.anl.gov) (630)252-5417 Beamline Controls Group (www.aps.anl.gov) Advanced Photon Source, Argonne National Lab


From: Engbretson notifications@github.com Sent: Friday, October 5, 2018 9:38:53 AM To: epics-modules/ip Cc: Mooney, Tim M.; Assign Subject: Re: [epics-modules/ip] Do the op/ui files belong in op/ui/autoconvert? (#14)

Pete’s answer is the convention (from a recent group meeting) that bcda would like to be consistent everywhere so that the scripts which create/autoconvert the opi’s and ui’s will always be up to date with the adl files, but if someone tweaks any of these files, they don’t get trashed by an adl update. So the path hierarchy of where to look is known.

Which implies that across the board, only adl files should be in the expected locations and everything else should now be living in one of the autoconvert locations. There should never be anything in ui or edl since that already implies that there are not consistent with adl.

From: Mark Rivers notifications@github.com Sent: Friday, October 5, 2018 9:12 AM To: epics-modules/ip ip@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [epics-modules/ip] Do the op/ui files belong in op/ui/autoconvert? (#14)

The manually-tweaked files are in op/ui while op/Makefile only updates op/ui/autoconvert (from op/adl)

I understand that. That would imply that all ~100 files in op/ui were manually tweaked, and there no autoconverted files because the autoconvert directory is empty. I find this highly doubtful. I have done a "git log" on a number of the files, and the last commit for each was Sept. 11, 2014 with the same commit message.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/epics-modules/ip/issues/14#issuecomment-427379672, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AM66i4Jy41p4V_R7FS9Yw24sWDi2NTn3ks5uh2i2gaJpZM4XKORa.

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHubhttps://github.com/epics-modules/ip/issues/14#issuecomment-427388468, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AGfnlwh3wQ3OK_lcjKSjswSUloMkPYzzks5uh279gaJpZM4XKORa.

MarkRivers commented 5 years ago

There should never be anything in ui or edl since that already implies that there are not consistent with adl.

I don't think this is quite correct. ui or edl can contain completely new files that exploit the features of that OPI and hence cannot be represented in medm. They could also contain "tweaked" versions of the converted screens, although I would discourage this since one will need to decide which to copy to a distribution directory.

Engbretson commented 5 years ago

Hmmm, your correct. But this would mean having at least 3 levels of redirection – the version converted from ADL, the native enhanced feature version, and then beam line modifications/ working versions.

From: Mark Rivers notifications@github.com Sent: Friday, October 5, 2018 1:13 PM To: epics-modules/ip ip@noreply.github.com Cc: Engbretson Engbretson@anl.gov; Comment comment@noreply.github.com Subject: Re: [epics-modules/ip] Do the op/ui files belong in op/ui/autoconvert? (#14)

There should never be anything in ui or edl since that already implies that there are not consistent with adl.

I don't think this is quite correct. ui or edl can contain completely new files that exploit the features of that OPI and hence cannot be represented in medm. They could also contain "tweaked" versions of the converted screens, although I would discourage this since one will need to decide which to copy to a distribution directory.

— You are receiving this because you commented. Reply to this email directly, view it on GitHubhttps://github.com/epics-modules/ip/issues/14#issuecomment-427453625, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AM66i5oFHSE_FI-rqS23Ik2q79-giopwks5uh6EZgaJpZM4XKORa.

keenanlang commented 5 years ago

Fixed with the following commits:

a5d1f3c eeebbf8 44135ef 793e571 6c107d2 ec1eda2 74b699e de0deb5 efd44a4 6d6287a