search

epics-modules / motor

APS BCDA synApps module: motor
https://epics-modules.github.io/motor/
20 stars 47 forks source link

Don't set "stop" field true if driver returns RA_PROBLEM true #109

Closed kmpeters closed 6 years ago

kmpeters commented 6 years ago

Partially reverts commit 303a9208e368ef07839afff67bac69e429af7332

Fixes issue #100:

There have been multiple problems caused by the motor record sending a stop when the problem bit is set.

One problem is discussed here: https://epics.anl.gov/tech-talk/2018/msg01338.php

The commit that introduced the stop is 303a920. I vaguely recall the change being a workaround for less-than-idea behavior of a motor controller, but neither @rsluiter nor I remember which controller that was.

Motor drivers should be modified to send the stop command when the condition that triggers the setting of the problem bit is detected, if needed.