search

epics-modules / motor

APS BCDA synApps module: motor
https://epics-modules.github.io/motor/
20 stars 47 forks source link

devOmsCom.cc is not completely device independent #179

Closed hjunkes closed 1 year ago

hjunkes commented 2 years ago

In devOmsCom.cc the hard-coded driver table of the oms58 is used. I don't understand the construct, but shouldn't e.g. when using a MAXv card, the driver table of that card (MAVv_access) be accessed?

Line 247: if ((command == PRIMITIVE) && (mr->init != NULL) && (strlen(mr->init) != 0)) { extern struct driver_table oms58_access; / Test for a "device directive" in the Initialization string. / if ((mr->init[0] == '@') && (trans->tabptr == &oms58_access)) { char *end = strrchr(&mr->init[1], '@'); if (end != NULL) {

kmpeters commented 1 year ago

Closing this issue in favor of the new one in motorOms.