search

epics-modules / motor

APS BCDA synApps module: motor
https://epics-modules.github.io/motor/
20 stars 47 forks source link

Include motorSymetrie in motor #185

Closed kmpeters closed 2 years ago

kmpeters commented 2 years ago

A place to discuss what needs to be done to include motorSymetrie in motor

MarkRivers commented 2 years ago

The current version of motorSymetrie does not include support for the motor record. I am working on that.

kmpeters commented 2 years ago

Do you propose waiting until the motor-record support is done to include motorSymetrie in motor? I'm not opposed to including it before then.

It worries me a little bit that pmac depends on Diamond-specific forks of synApps modules. I'm able to build pmac & motorSymetrie, but I don't know if the support depends on changes in Diamond's version of motor that aren't included in this module.

MarkRivers commented 2 years ago

@kmpeters it is actually not possible to include motorSymetrie in motor. The problem is that pmac is not part of motor, but pmac depends on motor. If motorSymetrie is part of motor there is a circular dependency, because the pmac depends on motor and motor depends on pmac.

I have moved motorsSymetrie to be a top-level module in support, and that works fine.

There is also an issue that pmac does not work on Windows shareable, e.g. windows-x64 architecture, because it lacks the epicsShareClass definitions and export.h is in the wrong location. I am working on fixing that, but for now I have change the motorSymetrie Makefile to only build on Linux.

We should probably close this issue.

kmpeters commented 2 years ago

Sounds good.