Closed bsobhani closed 1 year ago
That was fixed in this commit: 784e41927b942d38c31a766309668d6114861b9e on April 19, 2021.
R7-2-2 is from February 2, 2021 so it is not in that release.
That was fixed in this commit: 784e419 on April 19, 2021.
R7-2-2 is from February 2, 2021 so it is not in that release.
It appears to me that as of 11-July-2022 and using the assemble_synApps.sh
bash script to do a lot of the heavy-lifting for grabbing source files, this issue still exists.
e.g. I did a fresh install of synapps using the assemble_synApps.sh
script, modified the RELEASE file and did a make. The same errors as OP came up during (attempted) compilation of motordevCom.cc
Is this simply a pull-request needing to be made?
I did a fresh install of synapps using the assemble_synApps.sh script, modified the RELEASE file and did a make. The same errors as OP came up during (attempted) compilation of motordevCom.cc
Are you talking about this version of assemble_synApps.sh: https://github.com/EPICS-synApps/support/blob/master/assemble_synApps.sh
That still uses motor R7-2-2, which is still the most recent motor release.
Is this simply a pull-request needing to be made?
No, there is no need for a pull-request, I have already made the commit on the master branch. All that it needed is for someone to make new tag of the motor module, e.g. R7-2-3 or R7-3.
For now you can just do the following:
cd support/motor-7-2-2
git checkout master
git pull
That may not work if you did not run assemble_synApps.sh with the "full" argument to get full clones. In that case you may need to do a fresh full clone of motor.
git clone --recursive https://github.com/epics-modules/motor
@MarkRivers - thanks for the info. For this particular fix, I just modified the local source file to add the include.
I was posting the question more as a public service in that others may encounter the same issue until the tag is updated - I realize now the issue is rooted a bit deeper than than at the synapps/support repo.
In summary, when I cloned the synapps/support repo with: git clone https://github.com/EPICS-synApps/support.git
the assemble_synApps.sh does its thing and eventually fails with this issue #187
But I guess the root-cause is the tag within the motor record repo, so there is nothing that can (or should) be done from the synApps perspective?
No, there is no need for a pull-request, I have already made the commit on the master branch. All that it needed is for someone to make new tag of the motor module, e.g. R7-2-3 or R7-3.
This is on my TODO list. I'm currently drowning in other issues, though.
I will be tagging a new release very soon.
When I try to compile synapps with the following (these are all the current defaults):
and using epics base R7.0.6.1, I get the following compilation error message from motor record:
But when instead of using the tagged version I clone the master branch of motor record, and use the same release file, it compiles without issue.