search

epics-modules / motor

APS BCDA synApps module: motor
https://epics-modules.github.io/motor/
20 stars 47 forks source link

Github Actions builds fail on Windows #194

Closed kmpeters closed 1 year ago

kmpeters commented 1 year ago

The build is using base 7.0 even though the config specifies base 3.15.

kmpeters commented 1 year ago

It looks like the github actions builds were always using base 7.0. I still don't know why.

prjemian commented 1 year ago

https://github.com/epics-modules/motor/blob/302d4d61fc374dfd23c8a7dcdadeb4937cce40bc/.github/workflows/ci-scripts-build-full.yml#L44 https://github.com/epics-modules/motor/blob/302d4d61fc374dfd23c8a7dcdadeb4937cce40bc/.github/workflows/ci-scripts-build-full.yml#L60 ...

Looks like this is a manually-controlled item.

kmpeters commented 1 year ago

Yes, but the windows config looks like this:

https://github.com/epics-modules/motor/blob/302d4d61fc374dfd23c8a7dcdadeb4937cce40bc/.github/workflows/ci-scripts-build.yml#L62-L67

anjohnson commented 1 year ago

Just at the moment there's a known issue with the tip of the Base 7.0 branch which I have a fix for, although I've only seen it affect Appveyor builds myself. In general I'd probably recommend that you switch to using a release tag version for testing so you don't get hit by these kinds of problems.

kmpeters commented 1 year ago

There still might be something wrong with my github actions config.

prjemian commented 1 year ago

In the logs for the Win build, here's where base-7.0 was identified:

2022-11-30T15:27:29.3791751Z D:\a\motor\motor>call "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" amd64 
2022-11-30T15:27:30.0013274Z **********************************************************************
2022-11-30T15:27:30.0013647Z ** Visual Studio 2019 Developer Command Prompt v16.11.21
2022-11-30T15:27:30.0014566Z ** Copyright (c) 2021 Microsoft Corporation
2022-11-30T15:27:30.0015114Z **********************************************************************
2022-11-30T15:27:31.9176878Z [vcvarsall.bat] Environment initialized for: 'x64'
2022-11-30T15:27:32.0426086Z Build using vs2019 compiler on windows (x64) hosted by github-actions
2022-11-30T15:27:32.0426793Z Python setup
2022-11-30T15:27:32.0427294Z 3.7.9 (tags/v3.7.9:13c94747c7, Aug 17 2020, 18:58:18) [MSC v.1900 64 bit (AMD64)]
2022-11-30T15:27:32.0427748Z PYTHONPATH
2022-11-30T15:27:32.0428108Z   D:\a\motor\motor\.ci
2022-11-30T15:27:32.0428572Z   D:\a\_actions\mdavidsaver\ci-core-dumper\master
2022-11-30T15:27:32.0429011Z   D:\a\motor\motor
2022-11-30T15:27:32.0429473Z   C:\hostedtoolcache\windows\Python\3.7.9\x64\python37.zip
2022-11-30T15:27:32.0429963Z   C:\hostedtoolcache\windows\Python\3.7.9\x64\DLLs
2022-11-30T15:27:32.0430449Z   C:\hostedtoolcache\windows\Python\3.7.9\x64\lib
2022-11-30T15:27:32.0430942Z   C:\hostedtoolcache\windows\Python\3.7.9\x64
2022-11-30T15:27:32.0431439Z   C:\hostedtoolcache\windows\Python\3.7.9\x64\lib\site-packages
2022-11-30T15:27:32.0431901Z platform = win-amd64
2022-11-30T15:27:32.0432333Z Available Visual Studio versions
2022-11-30T15:27:32.0432909Z vs2019 in C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build\vcvarsall.bat
2022-11-30T15:27:32.0433491Z vs2015 in C:\Program Files (x86)\Microsoft Visual Studio 14.0\VC\vcvarsall.bat
2022-11-30T15:27:32.0434593Z ##[group]Loading setup files
2022-11-30T15:27:32.0435049Z Opening setup file .ci-local\modules.set
2022-11-30T15:27:32.0435497Z Opening setup file .ci\defaults.set
2022-11-30T15:27:32.0436074Z ##[endgroup]
2022-11-30T15:27:32.2047781Z ##[group]Checking/cloning dependencies
2022-11-30T15:27:32.6985176Z 8969a952e4853dfe45156eab2a7176498fa5e86b   refs/heads/7.0
2022-11-30T15:27:32.7045992Z Cloning 7.0 of dependency BASE into C:\Users\runneradmin\.cache\base-7.0
2022-11-30T15:27:57.9109209Z commit 8969a952e4853dfe45156eab2a7176498fa5e86b
kmpeters commented 1 year ago

Does that make it obvious to you what is wrong with the config? I'm not seeing the mistake.

prjemian commented 1 year ago

Not so obvious to me, which is why I support Andrew's suggestion.

kmpeters commented 1 year ago

I'll try that.

anjohnson commented 1 year ago

This error from your build is what I need to fix in Base, so using 7.0.7 should fix the problem:

dbdExpand.pl: No input files for dlload.dbd
kmpeters commented 1 year ago

This change fixed the problem of the specified versions of base being ignored:

https://github.com/epics-modules/motor/pull/195/commits/566f47073682973f185ee76ee7ddfbeab74bb442

I'm not including the base version in the modules.set file. I suspect I based the ci-scripts-build.yml file on ci-scripts-build.yml.example-full from the ci-scripts module, which also doesn't set the BASE env var based on matrix.base:

[host ~/development/epics-modules/ci-scripts/github-actions]$ ls -l
total 16
-rw-rw-r-- 1 user group 6207 Nov 30 12:54 ci-scripts-build.yml.example-full
-rw-rw-r-- 1 user group 1956 Nov 30 12:54 ci-scripts-build.yml.example-mini
-rw-rw-r-- 1 user group 2605 Nov 30 12:54 README.md
[host ~/development/epics-modules/ci-scripts/github-actions]$ grep -ir matrix.base .
./ci-scripts-build.yml.example-mini:      BASE: ${{ matrix.base }}
[host ~/development/epics-modules/ci-scripts/github-actions]$