epics-modules / mrfioc2

EPICS driver for Micro Research Finland event timing system devices
http://epics-modules.github.io/mrfioc2/
Other
8 stars 29 forks source link

feat: Packaging mrf dkms as a deb package #128

Closed gabrielfedel closed 4 months ago

gabrielfedel commented 4 months ago

This is a PR of the the debian packaging for mrf dkms, and it is my first debian package so sorry if there is something too unconventional.

With this PR it is possible to build a .deb package that works for Debian (tested on 10) and Ubuntu (tested on 22.04).

Some important points:

gabrielfedel commented 4 months ago

I'm trying to rename the package to mrfioc2-dkms, but this make the installation process attached to that name and it looks for a mrfioc2.ko (it might be ways to work around that but I'm not finding them) . Any suggestions on how to proceed ? Move the driver to mrfioc2 ? or keep the package as mrf-dkms ? Or a third option ?

jerzyjamroz commented 4 months ago

I changed the .rpm accordingly: https://github.com/epics-modules/mrfioc2/pull/129 If there is another preference then comments are welcome. It would be good to keep the consistency across different package types.

jerzyjamroz commented 4 months ago

@lucmaga , support the review.

gabrielfedel commented 4 months ago

Ok, the package is ready to be reviewed.

lucmaga commented 4 months ago

Tested on Ubuntu also, works as expected. Only thing I would add, maybe it does not fit in this PR, is to automatically do it using CI for the releases.

Anyway, LGTM.