epics-modules / mrfioc2

EPICS driver for Micro Research Finland event timing system devices
http://epics-modules.github.io/mrfioc2/
Other
8 stars 29 forks source link

fix: fix MTCA-EVR-300u substitutions file #138

Closed Insomnia1437 closed 3 months ago

Insomnia1437 commented 4 months ago

evr-mtca-300u.substitutions will generate db name like this: $(P)$(dsh=-)Out$(s=:)FP0$(ES)Src:Scale-SP But I think this should be better, $(P)$(dsh=-)Out$(s=:)FP0$(ES)Src$(s=:)Scale-SP Thus user can have a consistent record name (e.g. no :) by changing macro s during dbLoadRecords

I also add more pulsers & IO and fix bug of CML waveform size. If ES, dsh and s are empty, evr-mtca-300u.substitutions and evr-mtca-300u.uv.substitutions now generate the same records.

jerzyjamroz commented 3 months ago

@zioven , the update is related to evr-mtca-300u.substitutions, could you review that?

zioven commented 3 months ago

I have looked at the changes and tested the code, and I found no issues

This can be merged from my perspective