epics-modules / mrfioc2

EPICS driver for Micro Research Finland event timing system devices
http://epics-modules.github.io/mrfioc2/
Other
8 stars 30 forks source link

Adding the PLL Bandwidth adjustments for EVM and EVR #152

Closed hongran closed 4 months ago

hongran commented 4 months ago

I combined a few commits from Tony's original PR. The PLL bandwidth choice should be applicable to other card types (pcie, mtca, ...). I have tested with the VME cards. Let me know if it works for mtca or pcie cards. The screen updates are not in this PR. I tested it via the EPICS record.

hongran commented 4 months ago

I just pushed a new commits with the changes to the db files.

hongran commented 4 months ago

I just found a bug in the EVR code. It is corrected and I verified that the VME register changes as expected.

gabrielfedel commented 4 months ago

@hongran Looks fine, could you just squash the commits into one. I think would be better to have this change as only 1 commit. After that I can merge it.

hongran commented 4 months ago

All changes are combined.

gabrielfedel commented 4 months ago

Great! LGTM!