search

epics-modules / mrfioc2

EPICS driver for Micro Research Finland event timing system devices
http://epics-modules.github.io/mrfioc2/
Other
8 stars 30 forks source link

Records for EVR event clock mode #156

Closed hongran closed 4 months ago

hongran commented 4 months ago

There are two commits. 1: Added recrods for EVR event clock mode selection 2: Removed a few duplicated DESC fields in the evrbase.db

Insomnia1437 commented 4 months ago

@hongran EVR clock mode record has already been defined here, I think it is better to change this instead of using a new record. https://github.com/epics-modules/mrfioc2/blob/master/evrMrmApp/Db/mrmevrbase.template

hongran commented 4 months ago

@hongran EVR clock mode record has already been defined here, I think it is better to change this instead of using a new record. https://github.com/epics-modules/mrfioc2/blob/master/evrMrmApp/Db/mrmevrbase.template

Yes. Since the functions are defined within evrMrm, I will move the records there.

gabrielfedel commented 4 months ago

Looks good to me, @Insomnia1437 any other comment ? Otherwise I will merge

Insomnia1437 commented 4 months ago

@gabrielfedel LGTM as well