search

epics-modules / mrfioc2

EPICS driver for Micro Research Finland event timing system devices
http://epics-modules.github.io/mrfioc2/
Other
8 stars 30 forks source link

VME EVM-300 changes #52

Open afpietryla opened 3 years ago

afpietryla commented 3 years ago

Included are the changes I've made so far to add support for the VME version of the EVM-300.

I am particularly interested in how to handle the changes for the last commit, so that backward compatibility is maintained.

afpietryla commented 3 years ago

GIthub no longer running builds.

mdavidsaver commented 3 years ago

If you can rebase you will pick up the new configuration for github actions.

anjohnson commented 3 years ago

This is weird, GitHub actions has run the build for Tony's repo after he rebased, but it isn't even noticing the new commits here, let alone running the actions. Are you aware of some kind of a quota which epics-modules might have run out of?

mdavidsaver commented 3 years ago

Maybe an approval thing? I don't see an "Approve and run" button, but I'm not sure if I am an admin for the epics-modules org.

mdavidsaver commented 3 years ago

There is definite weirdness. I get an error "Unable to re-run disabled workflow. " when I try to re-run that last successful build.

mdavidsaver commented 3 years ago

Ok, maybe my doing. I was experimenting with scheduling a "monthly" build as "surveillance" for dependency problems. However, it seems that GHA will helpfully disable the workflow if there has been no repository activity in the past 60 days. Thank you GHA.

I'll be removing this...

https://github.com/epics-modules/mrfioc2/blob/0ce53468b1e35d5a4a801f72b99ab4189786b267/.github/workflows/ci-scripts-build.yml#L23-L24

I've re-enabled the workflows, and started re-running the last jobs. Nothing has changed with this PR, but that might happen on the next push.

anjohnson commented 3 years ago

@hongran @afpietryla The commit e2f9306 that Ran just pushed to this branch needs to be removed or backed out, these changes are not appropriate for this pull request, which is anchored to the github branch.

afpietryla commented 3 years ago

I believe I addressed all your comments. Please review again. Thanks.

afpietryla commented 3 years ago

I believe I addressed all your comments. Please review again. Thanks.