search

epics-modules / mrfioc2

EPICS driver for Micro Research Finland event timing system devices
http://epics-modules.github.io/mrfioc2/
Other
8 stars 30 forks source link

Add support for MTCA EVR 300U and 300RF #89

Closed zioven closed 12 months ago

zioven commented 12 months ago

Hi,

Some time ago my coworker provided pull request #63 for the 300U and 300RF versions of the EVR.

Can somebody provide guidance what is needed to include those two versions into main release?

Best regards,

Žiga

jerzyjamroz commented 12 months ago

Hi, I uploaded first the naming agreements as in the future, the mrfioc2 should be able to follow unified naming standards. One of the modifications looks like this: https://github.com/epics-modules/mrfioc2/pull/63/commits/2d49873cae13510d46edbeae3373c4a989cae759 It means: $(SYS){$(D)}Xxx:Yyy:1 is changed now to: $(P)XxxYyy1. All the previous .substitutions files are still valid (the backward compatibility is kept). It also means that you can still add the old way .substitutions. The future way: https://github.com/epics-modules/mrfioc2/blob/master/evrMrmApp/Db/evr-300.substitutions

jerzyjamroz commented 12 months ago

I tried a preliminary run of your implementation merged to a test master and I got 6331 Segmentation fault while just master works fine. I will investigate if it is my setup or what is the reason. I think It would be good to rebase this PR to the actual master as well.

jerzyjamroz commented 12 months ago

Hi, I will close this thread as the PR https://github.com/epics-modules/mrfioc2/pull/63 would be enough for future details.