search

epics-modules / optics

APS BCDA synApps module: optics
http://epics-modules.github.io/optics/
Other
1 stars 3 forks source link

Vmas #13

Closed mdwyman closed 1 year ago

mdwyman commented 1 year ago

Added db files, example substitutions file, example iocsh file, and UI screens for variable mask aperture slits (white beam slits) being installed of upgrade

prjemian commented 1 year ago

@mdwyman, the .loglogin file should be deleted.

Should the xxx: references in vmas.iocsh be replaced with $(PREFIX)? This is probably a question for @keenanlang.

For example: https://github.com/BCDA-APS/apstools/blob/c36b881bc1ba1e5c1b893f26c1921ca7ae1603e6/.gitignore#L31-L33

mdwyman commented 1 year ago

@kmpeters Took out .loglogin (updated .gitignore as @prjemian suggested) and since I was already using macros for the motors in the example, I went ahead and swapped out the xxx: for $(P).

kmpeters commented 1 year ago

@mdwyman, it looks good to me. Are there any more changes you want to make to this PR before I merge it?

mdwyman commented 1 year ago

@kmpeters I thinks it's ready to go.