search

epics-modules / xspress3

EPICS areaDetector xspress3 module
GNU Lesser General Public License v3.0
4 stars 18 forks source link

fixing typo, ADXSPRESS3 is not provided by envPaths, XSPRESS3 is. tested #14

Closed oksanagit closed 4 years ago

oksanagit commented 4 years ago

Hello, I think this is a typo somehow crept in, unless there is more to it. ADXSPRESS3 macro is not defined anywhere. It is my understanding XSPRESS3 was meant. Thanks.

newville commented 4 years ago

@oksanagit Yes, I agree that should be XSPRESS3 instead of ADXSPRESS3. Apparently, we don't test all the iocs! It looks like ADXSPRESS3 is still used for other st.cmd files for other iocs too. Are you willing to fix those too?

If this is called 'iocxspress3-4Channel` and not explicitly linked to an example site-location, perhaps the PREFIX should be left as a generic 'XSPRESS3:'.

oksanagit commented 4 years ago

Sure, no problem, I will grep ADXSPRESS3 .

newville commented 4 years ago

@oksanagit Thanks, I'll merge this. It sure would be nice to come up with a better way to set the PREFIX!