epics-motor / motorPIGCS2

EPICS asyn motor drivers for PI GCS2 controllers
2 stars 4 forks source link

Bug fix and new function for Control Loop #25

Closed guirodrigueslima closed 3 months ago

guirodrigueslima commented 4 months ago

Hello @kmpeters, how are you?

I'm submitting some improvements that were made with Augusto Yoshio Horita in the Control Loop. These improvements include some optimizations, bug fixes and new functions such as AnalogInput, Over Flow, On-Targer and Error. These improvements have been running on the Carnauba beamline at Sirius/CNEPM for over a year and have already prevented collision accidents in the past.

Three new PVs were added (Analog Target Input, On-Target and Over Flow). Furthermore, a bug was observed where only the PID configurations for axis 1 were working, so the PIasynAxis::createCLParams() function was removed from the loop and now createParam() is instantiated only once in PIasynController::PIasynController( ), the values are defined by the ADDR variable of each respective axis.

The PV LAST_ERR was removed from PI_SupportCtrl.db, as this database only works for controllers with a coordinate system. The PV was added to the PI_SupportError,db file and a new PV was also created to clear the last CLEAR_ERR error.

I'm currently working on the C-887 controller for hexapod to support based on Work and Tool Coordinate system, but first I want to bring these new improvements in control loop.

Thanks.