search

epics-motor / motorSmarAct

EPICS motor drivers for SmarAct controllers
3 stars 13 forks source link

reindent, merge features of MCS driver that were lost from version 1.5.0 #22

Closed ganymede42 closed 11 months ago

kmpeters commented 12 months ago

@ganymede42, can you revert 82417df and submit it as its own pull req? Formatting and content changes in a single pull req makes it very hard to see what actually changed.

ganymede42 commented 11 months ago

can't you just check the individual commits if you do not trust the final result ? That was the reason to do the indent in an independent commit... but it makes no sense to create multiple pull requests for that in my opinion. The files were very inconsistently formatted and features from 1.5.0 were lost. It was a hard work to clean up all stuff and we have now AGAIN MCS1 and MCS2 working correctly at PSI what was not the situation with release R2-1. To make you more confident with my name: I work together with Dirk Zimoch ,Scott, Zan, and earlier with Niko Kivel at PSI and we have more that 150 SmarActs with MCS1 and MCS2 running at SwissFEL.

kmpeters commented 11 months ago

I replied in #23.

The issue is not that I lack confidence in who you are. The issue is that I have a limited amount of time to spend reviewing pull requests. Combining formatting and functional changes makes the job of reviewing changes harder, which greatly increases the likelihood that the review of the pull request will be delayed.