search

epics-motor / motorSmarAct

EPICS motor drivers for SmarAct controllers
3 stars 13 forks source link

reindent code / merge features of MCS driver that were lost since from version 1.5.0 #23

Closed ganymede42 closed 11 months ago

ganymede42 commented 11 months ago

The pull request consists of 2 commits:

  1. reindent anf formating code -> code consistency has been checkt with bcompare

  2. many changes on MCS to support rotary encoder and to set the positioner type further this commit contains also many improvements of the MCS2 code

  3. reindent, delete trailling spaces, remove unused variables

  4. MCS: merge lost features from 1.5.1, MCS2: various

    • merge features of MCS driver that were lost since from version 1.5.0
      • Add PTYPE, MCF, AUTO_ZERO, CAL option
      • Fix jog for rot stages
    • support PTYPE, MCF and other MCS/MCS2 specific functionalities
    • MCS2: fix polling when there are missing positioner
    • MCS2: support positioners without encoder
    • simplify debugging with DBG_PRINTF
kmpeters commented 11 months ago

I can't merge this pull request; Commit bbccfdfc40133059eabf35f2134b9995de570c0f removes improvements that were added in #7.

Also, are the references to versions 1.5.0 and 1.5.1 typos? I only see versions 1.2.0 and 1.2.1.

ganymede42 commented 11 months ago

Version 1.5.1 were improvments that have been done by Zan at PSI... sorry not part of the official repo. I will try to make smaller steps, first with the cleanup of the code