search

epics-rip / org.csstudio.product

CS-Studio General Product
1 stars 7 forks source link

Updated preference category name #18

Closed claudio-rosati closed 8 years ago

claudio-rosati commented 8 years ago

Changed the name of the General preference category from introCustomizationPreference to Welcome Page.

berryma4 commented 8 years ago

Shouldn't this be: name="%introCustomizationPreference.name" and it's filled in by property? @shroffk @kasemir @willrogers

kasemir commented 8 years ago

Where do you define introCustomizationPreference.name? In org.csstudio.product/plugin.properties?

claudio-rosati commented 8 years ago

No, in org.csstudio.product/plugin.xml. org.csstudio.product/plugin.properties contains only the definition of "aboutText"

claudio-rosati commented 8 years ago

I've tried the @berryma4 solution and it works, so now it is in the plugin.properties file. Have I to do another pull-request and closing this one?

kasemir commented 8 years ago

Ordinarily you can keep pushing commits to the branch, i.e. the ESSICS:master, and this pull request will then show the added commits. So no new pull request.

claudio-rosati commented 8 years ago

I've committed the changes.

berryma4 commented 8 years ago

thank you!