search

epicserve / django-cache-url

Use Cache URLs in your Django Application
MIT License
18 stars 12 forks source link

Incompatibility when using `hiredis://` with Django 4 #20

Open matthiask opened 2 years ago

matthiask commented 2 years ago

django-cache-url adds PARSER_CLASS to the options dictionary when using hiredis://... but Django's built-in cache backend doesn't like that.

Thanks!

matthiask commented 2 years ago

By the way, recent enough versions of redis-py will automatically select the hiredis parser if it is available so you should be able to just skip specifying the parser class.

epicserve commented 2 years ago

@matthiask, want to make a PR?

matthiask commented 2 years ago

Thanks for asking! I'll politely decline since I'd rather spend more time on Jazzband projects, e.g. the debug toolbar. django-cache-url has served me well in the past (and still does) but since I've mostly switched to using https://github.com/matthiask/speckenv/blob/main/speckenv_django.py this isn't my own itch anymore. speckenv_django is a bit smaller, doesn't modify urllib.uses_netloc and does everything I need re. configuring databases, email sending and caching.

I hope I don't come across as a freeloader here. Thanks again!