search

epicserve / django-cache-url

Use Cache URLs in your Django Application
MIT License
18 stars 12 forks source link

Fix #28 -- Update Python and Django versions #29

Closed pauloxnet closed 9 months ago

pauloxnet commented 9 months ago

Ref #28

pauloxnet commented 9 months ago

@epicserve can you unlock the Python 3.7 required step and review this PR

epicserve commented 9 months ago

@pauloxnet, do we really need to have checks for so many permutations of Django and Python? Especially versions of Django that are no longer supported and versions of Python that are no longer supported.

epicserve commented 9 months ago

@pauloxnet, I'm not seeing an obvious way to unlock Python 3.7 tests from running.

pauloxnet commented 9 months ago

@pauloxnet, do we really need to have checks for so many permutations of Django and Python? Especially versions of Django that are no longer supported and versions of Python that are no longer supported.

As for the permutations, I would leave all those Django/Python supported versions

If you are referring to Django 4.1 EOL, when I opened the PR it was still supported :-D

Python 3.8 however will still be supported until October 2024

Given today's releases, I will update this PR

pauloxnet commented 9 months ago

@pauloxnet, I'm not seeing an obvious way to unlock Python 3.7 tests from running.

I think it's because I removed Python 3.7.

Where "un Python 3.7 tests " is defined as "required"? In the code or the repo settings?

pauloxnet commented 9 months ago

@epicserve you were faster than me. Thanks for the release