fix: redis 4 adapter not an integer or out of range error

epicweb-dev / cachified

🤑 wrap virtually everything that can store by key to act as cache with ttl/max-age, stale-while-validate, parallel fetch protection and type-safety support

MIT License

916 stars 26 forks source link

fix: redis 4 adapter not an integer or out of range error #18

Closed TapaiBalazs closed 1 year ago

TapaiBalazs commented 1 year ago

In this PR

Added Math.ceil() to the redisAdapter EXAT parameter to prevent ERR value is not an integer or out of range errors with real redis instances
Updated the redis 4 related test.

Closes #17

Please note that you can entirely disregard my PR if you have a better solution. If I had time, I would have changed the tests in a way, that Date.now() would return a more real-like timestamp, but that would also require me to update all other tests.

Xiphe commented 1 year ago

Cool 👍 thanks for the contribution

Xiphe commented 1 year ago

damn, hit enter to early while editing the commit message. My bad 😅

github-actions[bot] commented 1 year ago

:tada: This PR is included in version 3.0.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: