search

epicweb-dev / epic-stack

This is a Full Stack app starter with the foundational things setup and configured for you to hit the ground running on your next EPIC idea.
https://www.epicweb.dev/epic-stack
MIT License
4.9k stars 397 forks source link

Vitest fails on clean installation #189

Closed andrecasal closed 1 year ago

andrecasal commented 1 year ago

GitHub Action result on a clean installation (without deploying to Fly):

Screenshot 2023-06-15 at 15 06 44
andrecasal commented 1 year ago

I tried again deploying to Fly and Vitest passed, but I can't identify anything the remix.init script might be doing differently that would influence this test.

kentcdodds commented 1 year ago

That test is time-based which can often be flaky if you're not careful (especially on slower CI machines), but we're mocking time so I'm not sure what's going on here. I'll look into it.

kentcdodds commented 1 year ago

We're set here now