search

epicweb-dev / epic-stack

This is a Full Stack app starter with the foundational things setup and configured for you to hit the ground running on your next EPIC idea.
https://www.epicweb.dev/epic-stack
MIT License
4.9k stars 398 forks source link

`extended-theme` defining Accordion-specific keyframes... but no accordion is used anywhere #586

Closed simonswiss closed 11 months ago

simonswiss commented 11 months ago

The extended-theme is adding keyframes use for the Accordion (Radix UI) component only, and relying on Radix CSS variables — but no Accordion component is used anywhere in the app:

https://github.com/epicweb-dev/epic-stack/blob/3a9b80511361f40659b486e6721e0aeb7cadf2b2/app/utils/extended-theme.ts#L96-L99

This is a bit confusing, because those animation utilities will not work outside of Accordions (the CSS variables are missing), and... there are no Accordions used anywhere in the app.

Should these be removed, or is it here in case users want to start using Accordions?

kentcdodds commented 11 months ago

Yeah, that's a mistake. We can remove it.