search

epicweb-dev / epic-stack

This is a Full Stack app starter with the foundational things setup and configured for you to hit the ground running on your next EPIC idea.
https://www.epicweb.dev/epic-stack
MIT License
4.33k stars 355 forks source link

Typo in Dockerfile? #614

Closed ovistoica closed 7 months ago

ovistoica commented 7 months ago

I was looking at the Dockerfile and I see the cache db file path as

ENV LITEFS_DIR="/litefs/data"
...
ENV DATABASE_PATH="$LITEFS_DIR/$DATABASE_FILENAME"
...
ENV CACHE_DATABASE_FILENAME="cache.db"
ENV CACHE_DATABASE_PATH="/$LITEFS_DIR/$CACHE_DATABASE_FILENAME" #prefix /

Doesn't the CACHE_DATABASE_PATH evaluate to //litefs/data/cache.db ?

I think it is still read correctly but would be good to fix. Sorry for not providing a PR myself since I don't have the repo cloned

Hope this helps! Thank you for epic-stack & epic-web-dev. They are very helpful! 🙏

kentcdodds commented 7 months ago

You're right! Luckily it looks like it's working anyway, but I'll go ahead and fix that now. Thanks!