search

epicweb-dev / epic-stack

This is a Full Stack app starter with the foundational things setup and configured for you to hit the ground running on your next EPIC idea.
https://www.epicweb.dev/epic-stack
MIT License
4.63k stars 376 forks source link

The branch ref check in deploy might not be needed #628

Closed hilja closed 8 months ago

hilja commented 8 months ago

Correct me if I’m mistaken but this seems extra:

https://github.com/epicweb-dev/epic-stack/blob/534641c3920624263eb42056e2d258b343352b05/.github/workflows/deploy.yml#L143-L146

Since the push and the branches are already set:

https://github.com/epicweb-dev/epic-stack/blob/534641c3920624263eb42056e2d258b343352b05/.github/workflows/deploy.yml#L2-L6

kentcdodds commented 8 months ago

True. That could be simplified to just check for the event_name.

misiewiczmichal commented 8 months ago

Could I work on this? It would be my first PR.

kentcdodds commented 8 months ago

Sure!