search

epicweb-dev / epic-stack

This is a Full Stack app starter with the foundational things setup and configured for you to hit the ground running on your next EPIC idea.
https://www.epicweb.dev/epic-stack
MIT License
4.47k stars 368 forks source link

Fix StatusButton status when creating account. Add docs on GitHub OAuth app set up #675

Closed rustworthy closed 6 months ago

rustworthy commented 6 months ago

Addressing #671 and #657.

Test Plan

Checklist

Screenshots

rustworthy commented 6 months ago

As for the NODE_ENV in general, there are recommendations to avoid relying on it, since 3rd party libs can have various behavior (Nestjs, Express and others), depending on this var.

We could instead introduce our own dedicated variable e.g. CURRENT_ENVIRONMENT ("development" | "test" | "production") and set the NODE_ENV to "production" due to security concerns.

A report by Matteo Colina with a demo can be found here

Wdyt?

EDIT: in case this suggestion is supported, this comment will be turned into an issue and addressed in a separate PR